10000 Remove relative path references in adapters · Issue #2569 · sveltejs/kit · GitHub
[go: up one dir, main page]

Skip to content
Remove relative path references in adapters #2569
@benmccann

Description

@benmccann

Describe the bug

The best idea I have so far is that instead of writing the server output to .svelte-kit/output/server, we could try writing it to something like node_modules/@sveltejs/user-app (or maybe src/node_modules like Sapper does) with a package.json file:

		{
			"name": "@sveltejs/user-app",
			"version": "0.0.1",
			"private": true,
			"type": "module",
			"main": "app.js"
		}

The relative path is stopping adapter authors from using the types

I also think that after this is fixed that we can use Vite to do a single build pass instead of doing a second build step with esbuild in the adapters

Reproduction

For example:

// TODO hardcoding the relative location makes this brittle

We should make sure @jthegedus can consume the types in the firebase adapter after this is fixed

Logs

No response

System Info

`master`

Severity

annoyance

Additional Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0