8000 feat: adds `--install <package-manager>` flag to `create` and `add` by AdrianGonz97 · Pull Request #531 · sveltejs/cli · GitHub
[go: up one dir, main page]
Skip to content

feat: adds --install <package-manager> flag to create and add #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 13, 2025
Merged

feat: adds --install <package-manager> flag to create and add #531

merged 6 commits into from
Apr 13, 2025

Conversation

AdrianGonz97
Copy link
Member

closes #529

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Apr 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 404d8d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented Apr 10, 2025 •
edited
Loading

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@531

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@531

commit: a4a6927

@manuel3108
Copy link
Member

Looks good and works as expected. We should probably add this flag to the docs though

@manuel3108 manuel3108 mentioned this pull request Apr 11, 2025
Merged
@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-cli-531-svelte.vercel.app/

@manuel3108
Copy link
Member

Thats great. For --types we display two commands though:
image

We should at least unify the usage. I would prefer the way we currently have it for --types as i think it's more intuitive to understand, at least for people who have not that much experience with cli's. Happy to do the changes myself, but would love to hear your opinion

@AdrianGonz97
Copy link
Member Author
AdrianGonz97 commented Apr 12, 2025 •
edited
Loading

ah, nice catch

Happy to do the changes myself, but would love to hear your opinion

I won't have a chance to update until much later in the day, so feel free to update and merge!

manuel3108
manuel3108 approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member
@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I do wonder why we display options differently on the create and add pages altogether, but that's something we can fix at a later point

@manuel3108 manuel3108 merged commit c36a6a4 into main Apr 13, 2025
@manuel3108 manuel3108 deleted the feat/install-flag branch April 13, 2025 14:26
@github-actions github-actions bot mentioned this pull request Apr 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel3108 manuel3108 manuel3108 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --install option to sv create and sv add
2 participants
@AdrianGonz97 @manuel3108
0