8000 use different json serializer · Issue #95 · sveltejs/cli · GitHub
[go: up one dir, main page]
Skip to content

use different json serializer #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
manuel3108 opened this issue Oct 12, 2024 · 8 comments · Fixed by #157
Closed

use different json serializer #95

manuel3108 opened this issue Oct 12, 2024 · 8 comments · Fixed by #157

Comments

@manuel3108
Copy link
Member

See #67 (comment)
@manuel3108 manuel3108 mentioned this issue Oct 12, 2024
Merged
4 tasks
@AdrianGonz97
Copy link
Member

why a different json serializer? the linked comment is referring to js/ts

@manuel3108
Copy link
Member Author

Nope, it's used for generating a json file:

cli/packages/adders/paraglide/index.ts

Lines 80 to 87 in fb37e15

name: () => 'project.inlang/settings.json',
condition: ({ cwd }) => !fs.existsSync(path.join(cwd, 'project.inlang/settings.json')),
content: ({ options, content }) => {
const { data, generateCode } = parseJson(content);
for (const key in DEFAULT_INLANG_PROJECT) {
data[key] = DEFAULT_INLANG_PROJECT[key as keyof typeof DEFAULT_INLANG_PROJECT];
}

And thing similar happens here:

cli/packages/adders/paraglide/index.ts

Line 305 in fb37e15

jsonData['$schema'] = 'https://inlang.com/schema/inlang-message-format';

@manuel3108
Copy link
Member Author

Öhhhmm, in the last case at least we are using the node default serializer already. I wonder what's happening here...

@AdrianGonz97
Copy link
Member

oh, my bad then. i was referring to something related to recast. i haven't experienced any issues like that with the json serializer

@manuel3108
Copy link
Member Author

There is an open issue in silver-fleece as well evertheylen/silver-fleece#1

@manuel3108
Copy link
Member Author

Unaware of anything that would work better for us right now, so i created asked if they are open for a PR and created a PR

@manuel3108
Copy link
Member Author

my PR got merged, hoping this get's a small release so that we can get this in in time.

@benmccann
Copy link
Member

new version released 20 minutes ago

publint found some issues, but hopefully they don't prevent us from using the new release (evertheylen/silver-fleece#3)

@manuel3108 manuel3108 mentioned this issue Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(draft): update silver fleece sveltejs/cli
3 participants
@benmccann @manuel3108 @AdrianGonz97
0