8000 feat: unplugin-icons adder by Joex3 · Pull Request #555 · svelte-add/svelte-add · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Oct 20, 2024. It is now read-only.

feat: unplugin-icons adder #555

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Joex3
Copy link
@Joex3 Joex3 commented Aug 30, 2024

There is no issue for this change (I hope this is okay)

This PR adds an adder for unplugin-icons.

When adding, the user is prompted to install an optional icons collection:

grafik

The list can be updated by running node scripts/update-unplugin-icons-collections.

Copy link
changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: 9beb83e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
pkg-pr-new bot commented Aug 30, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/config@555
pnpm add https://pkg.pr.new/svelte-add/svelte-add@555

commit: 9beb83e

@manuel3108
Copy link
Member

Hey & thanks for your PR.

This looks awesome and works as expected, there is just one minor thing I noticed, although this might come from our tooling.
image

Though, after some internal discussions we have decided that the use-case is pretty niche, so that we don't want to convert this into an official adder. But we do think that this would be a great fit as a community adder!

Community adders are kinda possible right now (see this template), though they are not promoted in the official cli or anything. As you might have seen the activity in this repository has been getting quite low, that's because we are working on a lot of stuff behind the scenes.

If you are cool with this, I will get back to you once we have made more progress, to become the first community adder. Would that work for you?

@@ -0,0 +1,27 @@
/**
* This file is auto generated and can be updated by running:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very partial list, so I'm not sure how we'd decide which get listed here vs omitted. E.g. https://www.npmjs.com/package/@iconify-json/openmoji is missing. You can see all the icon sets at https://icon-sets.iconify.design/

@Joex3
Copy link
Author
Joex3 commented Sep 4, 2024

Thanks for the feedback 😄

If you are cool with this, I will get back to you once we have made more progress, to become the first community adder. Would that work for you?

Sounds good to me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0