fix: execute adders in order (#539)

AdrianGonz97 · web-flow · commit 6448b4ec262f · 2024-08-09T20:25:32.000+02:00
* small tweak

* execute in order

* changeset
diff --git a/.changeset/brown-beans-compare.md b/.changeset/brown-beans-compare.md
@@ -0,0 +1,5 @@
+---
+'@svelte-add/testing-library': patch
+---
+
+fix: execute adders in order
diff --git a/packages/core/utils/dependencies.ts b/packages/core/utils/dependencies.ts
@@ -16,21 +16,20 @@ export async function suggestInstallingDependencies(
 ): Promise<'installed' | 'skipped'> {
 	const detectedPm = await detect({ cwd: workingDirectory });
 	let selectedPm = detectedPm.agent;
-	if (!selectedPm) {
-		selectedPm = await selectPrompt(
-			'Which package manager do you want to install dependencies with?',
-			undefined,
-			[
-				{
-					label: 'None',
-					value: undefined,
-				},
-				...packageManagers.map((x) => {
-					return { label: x, value: x as PackageManager };
-				}),
-			],
-		);
-	}
+
+	selectedPm ??= await selectPrompt(
+		'Which package manager do you want to install dependencies with?',
+		undefined,
+		[
+			{
+				label: 'None',
+				value: undefined,
+			},
+			...packageManagers.map((x) => {
+				return { label: x, value: x as PackageManager };
+			}),
+		],
+	);
 
 	if (!selectedPm || !COMMANDS[selectedPm]) {
 		return 'skipped';
diff --git a/packages/testing-library/utils/test-cases.ts b/packages/testing-library/utils/test-cases.ts
@@ -125,23 +125,18 @@ export async function runTestCases(testCases: Map<string, TestCase[]>, testOptio
 	const tests: { testCase: TestCase; cwd: string }[] = [];
 
 	console.log('executing adders');
-	const setups = Array.from(testCases.values()).flatMap((values) =>
-		values.map((testCase) => {
-			const task = async () => {
-				if (testCase.adder.tests?.tests.length === 0) return;
-				const cwd = await setupAdder(
-					testCase.template,
-					testCase.adder,
-					testCase.options,
-					testOptions,
-				);
-				tests.push({ testCase, cwd });
-			};
-			return task();
-		}),
-	);
-
-	await Promise.all(setups);
+	for (const cases of testCases.values()) {
+		for (const testCase of cases) {
+			if (testCase.adder.tests?.tests.length === 0) continue;
+			const cwd = await setupAdder(
+				testCase.template,
+				testCase.adder,
+				testCase.options,
+				testOptions,
+			);
+			tests.push({ testCase, cwd });
+		}
+	}
 
 	console.log('installing dependencies');
 	await installDependencies(testOptions.outputDirectory);

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@svelte-add/testing-library': patch
 +---
++
 +fix: execute adders in order