fix typo peerConnectoinEvent -> peerConnectionEvent for EventChannel name (flutter-webrtc#1019)

doesnotexist · web-flow · commit 198c9e7081ca · 2022-07-20T10:36:30.000+08:00
diff --git a/android/src/main/java/com/cloudwebrtc/webrtc/PeerConnectionObserver.java b/android/src/main/java/com/cloudwebrtc/webrtc/PeerConnectionObserver.java
@@ -53,7 +53,7 @@ class PeerConnectionObserver implements PeerConnection.Observer, EventChannel.St
     this.messenger = messenger;
     this.id = id;
 
-    eventChannel = new EventChannel(messenger, "FlutterWebRTC/peerConnectoinEvent" + id);
+    eventChannel = new EventChannel(messenger, "FlutterWebRTC/peerConnectionEvent" + id);
     eventChannel.setStreamHandler(this);
   }
 
diff --git a/common/cpp/src/flutter_peerconnection.cc b/common/cpp/src/flutter_peerconnection.cc
@@ -227,7 +227,7 @@ void FlutterPeerConnection::CreateRTCPeerConnection(
       base_->factory_->Create(base_->configuration_, constraints);
   base_->peerconnections_[uuid] = pc;
 
-  std::string event_channel = "FlutterWebRTC/peerConnectoinEvent" + uuid;
+  std::string event_channel = "FlutterWebRTC/peerConnectionEvent" + uuid;
 
   std::unique_ptr<FlutterPeerConnectionObserver> observer(
       new FlutterPeerConnectionObserver(base_, pc, base_->messenger_,
diff --git a/common/darwin/Classes/FlutterWebRTCPlugin.m b/common/darwin/Classes/FlutterWebRTCPlugin.m
@@ -131,7 +131,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult) result
 
         /*Create Event Channel.*/
         peerConnection.eventChannel = [FlutterEventChannel
-                                       eventChannelWithName:[NSString stringWithFormat:@"FlutterWebRTC/peerConnectoinEvent%@", peerConnectionId]
+                                       eventChannelWithName:[NSString stringWithFormat:@"FlutterWebRTC/peerConnectionEvent%@", peerConnectionId]
                                        binaryMessenger:_messenger];
         [peerConnection.eventChannel setStreamHandler:peerConnection];
 
diff --git a/lib/src/native/rtc_peerconnection_impl.dart b/lib/src/native/rtc_peerconnection_impl.dart
@@ -222,7 +222,7 @@ class RTCPeerConnectionNative extends RTCPeerConnection {
   }
 
   EventChannel _eventChannelFor(String peerConnectionId) {
-    return EventChannel('FlutterWebRTC/peerConnectoinEvent$peerConnectionId');
+    return EventChannel('FlutterWebRTC/peerConnectionEvent$peerConnectionId');
   }
 
   @override
diff --git a/test/unit/rtc_peerconnection_test.dart b/test/unit/rtc_peerconnection_test.dart
@@ -12,7 +12,7 @@ void main() {
     channel.setMockMethodCallHandler((MethodCall methodCall) async {
       await ServicesBinding.instance.defaultBinaryMessenger
           .handlePlatformMessage(
-              'FlutterWebRTC/peerConnectoinEvent', null, (ByteData? data) {});
+              'FlutterWebRTC/peerConnectionEvent', null, (ByteData? data) {});
       await ServicesBinding.instance.defaultBinaryMessenger
           .handlePlatformMessage(
               'FlutterWebRTC/dataChannelEvent', null, (ByteData? data) {});

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ class PeerConnectionObserver implements PeerConnection.Observer, EventChannel.St`
`53`	`53`	`this.messenger = messenger;`
`54`	`54`	`this.id = id;`
`55`	`55`
`56`		`- eventChannel = new EventChannel(messenger, "FlutterWebRTC/peerConnectoinEvent" + id);`
	`56`	`+ eventChannel = new EventChannel(messenger, "FlutterWebRTC/peerConnectionEvent" + id);`
`57`	`57`	`eventChannel.setStreamHandler(this);`
`58`	`58`	`}`
`59`	`59`
Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ class RTCPeerConnectionNative extends RTCPeerConnection {`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`EventChannel _eventChannelFor(String peerConnectionId) {`
`225`		`- return EventChannel('FlutterWebRTC/peerConnectoinEvent$peerConnectionId');`
	`225`	`+ return EventChannel('FlutterWebRTC/peerConnectionEvent$peerConnectionId');`
`226`	`226`	`}`
`227`	`227`
`228`	`228`	`@override`