Remove unnecessary fail helpers

gzm0 · gzm0 · commit 23ea680b9d00 · 2019-06-18T12:55:40.000+02:00
They were most likely introduced to work around the lack of a
`Nothing` type in Java. `fail` seems not to be used in expression
position anymore, so we can use the one provided by JUnit directly.
diff --git a/test-common/src/test/scala/org/scalajs/testing/common/RPCCoreTest.scala b/test-common/src/test/scala/org/scalajs/testing/common/RPCCoreTest.scala
@@ -34,11 +34,6 @@ class RPCCoreTest {
     val msg1: MsgEndpoint.EP[Int] = MsgEndpoint[Int](5)
   }
 
-  private def fail(msg: String): Nothing = {
-    org.junit.Assert.fail(msg)
-    throw new AssertionError("Shouldn't reach here")
-  }
-
   @Test
   def simpleEndpoint: Unit = {
     var called = false
diff --git a/test-common/src/test/scala/org/scalajs/testing/common/RunMuxRPCTest.scala b/test-common/src/test/scala/org/scalajs/testing/common/RunMuxRPCTest.scala
@@ -35,11 +35,6 @@ class RunMuxRPCTest {
     val msg: MsgEndpoint.EP[RunMux[Unit]] = MsgEndpoint[RunMux[Unit]](3)
   }
 
-  private def fail(msg: String): Nothing = {
-    org.junit.Assert.fail(msg)
-    throw new AssertionError("Shouldn't reach here")
-  }
-
   @Test
   def muxedCall: Unit = {
     val called = Array.fill(10)(false)
