fix error when trying to output to non existing element

fpliger · fpliger · commit 3c2ca6d68c4c · 2022-04-18T23:10:41.000-05:00
diff --git a/pyscriptjs/examples/bokeh.html b/pyscriptjs/examples/bokeh.html
@@ -23,7 +23,7 @@
         <h1>Bokeh Example</h1>
         <div id="myplot"></div>
     
-    <py-script>
+    <py-script id="mycode">
 import json
 import pyodide
 
diff --git a/pyscriptjs/examples/bokeh_interactive.html b/pyscriptjs/examples/bokeh_interactive.html
@@ -23,7 +23,7 @@
         <h1>Bokeh Example</h1>
         <div id="myplot"></div>
     
-	<py-script>
+	<py-script id="my">
 import asyncio
 import json
 import pyodide
diff --git a/pyscriptjs/src/components/pyrepl.ts b/pyscriptjs/src/components/pyrepl.ts
@@ -188,7 +188,7 @@ export class PyRepl extends BaseEvalElement {
           this.errorElement = this.outputElement;
         }
       }
-  
+
 
       this.appendChild(mainDiv);      
       this.editor.focus();
diff --git a/pyscriptjs/src/components/pyscript.ts b/pyscriptjs/src/components/pyscript.ts
@@ -247,7 +247,7 @@ export class PyScript extends BaseEvalElement {
     }
 
     getSourceFromElement(): string {
-      return this.code;
+      return htmlDecode(this.code);
     }
   }
 
diff --git a/pyscriptjs/src/interpreter.ts b/pyscriptjs/src/interpreter.ts
@@ -22,6 +22,8 @@ class PyScript:
         if append:
             child = document.createElement('div');
             element = document.querySelector(f'#{element_id}');
+            if not element:
+                return
             exec_id = exec_id or element.childElementCount + 1
             element_id = child.id = f"{element_id}-{exec_id}";
             element.appendChild(child);
@@ -34,11 +36,9 @@ class PyScript:
             img_str = 'data:image/png;base64,' + base64.b64encode(buf.read()).decode('UTF-8')
             document.getElementById(element_id).innerHTML = f'<div><img id="plt" src="{img_str}"/></div>'
         elif hasattr(value, "startswith") and value.startswith("data:image"):
-            console.log(f"DATA/IMAGE: {value}")
             document.getElementById(element_id).innerHTML = f'<div><img id="plt" src="{value}"/></div>'
         else:
             document.getElementById(element_id).innerHTML = value;
-            console.log(f"ELSE: {append} ==> {element_id} --> {value}")
 
     @staticmethod
     def run_until_complete(f):

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ export class PyRepl extends BaseEvalElement {`
`188`	`188`	`this.errorElement = this.outputElement;`
`189`	`189`	`}`
`190`	`190`	`}`
`191`		`-`
	`191`	`+`
`192`	`192`
`193`	`193`	`this.appendChild(mainDiv);`
`194`	`194`	`this.editor.focus();`
Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ export class PyScript extends BaseEvalElement {`
`247`	`247`	`}`
`248`	`248`
`249`	`249`	`getSourceFromElement(): string {`
`250`		`- return this.code;`
	`250`	`+ return htmlDecode(this.code);`
`251`	`251`	`}`
`252`	`252`	`}`
`253`	`253`