8000 Setting initial view size causes error `Could not find '@render' socket` · Issue #130 · subsoap/defos · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting initial view size causes error Could not find '@render' socket #130

Closed
unindented opened this issue Sep 19, 2023 · 4 comments
Closed

Comments

@unindented
Copy link

If I add these lines to game.project (as described here in the README):

[defos]
view_width = 960
view_height = 540

The following error message gets printed on launch:

ERROR:ENGINE: Could not find '@render' socket.
@britzl
Copy link
Collaborator
britzl commented Sep 20, 2023

On which OS is this happening?

@unindented
Copy link
Author

@britzl sorry, forgot to include detailed info. This is on macOS, using Defold 1.5.0. Here's a recording, starting from a desktop template project:

repro-130.mp4

@AGulev
Copy link
Collaborator
AGulev commented Sep 21, 2023

@unindented it happens because when we change window size we are trying to send event to render script that window size has changed.
But there is no render_script exist at this point. So we can't send this message.

So this error just says "ok, I can't notify render_script" about window size change which isn't critical at all because at the moment when render_script will be created it will be able to use the new updated window size

I can fix it by moving window size change to the first update, but then window will be created with one size for a frame and changed to another right after that. It looks ugly tbh.
I would suggest keeping it as is

@unindented
Copy link
Author

@unindented it happens because when we change window size we are trying to send event to render script that window size has changed. But there is no render_script exist at this point. So we can't send this message.

So this error just says "ok, I can't notify render_script" about window size change which isn't critical at all because at the moment when render_script will be created it will be able to use the new updated window size

I can fix it by moving window size change to the first update, but then window will be created with one size for a frame and changed to another right after that. It looks ugly tbh. I would suggest keeping it as is

Nah, sounds good to leave as-is. I just needed that extra reassurance that nothing horrible is gonna happen down the line. Maybe worth adding a note in the README when talking about [defos] in game.project?

@AGulev AGulev closed this as completed in 2671ec9 Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
0