Apply suggestions from code review

dmichon-msft · octogonz · web-flow · commit 8d93e77cbbba · 2023-10-19T11:56:55.000-07:00
Co-authored-by: Pete Gonzalez &lt;4673363+octogonz@users.noreply.github.com&gt;
diff --git a/common/changes/@microsoft/rush/allow-skip-if-cache-disabled_2023-10-18-21-58.json b/common/changes/@microsoft/rush/allow-skip-if-cache-disabled_2023-10-18-21-58.json
@@ -2,7 +2,7 @@
   "changes": [
     {
       "packageName": "@microsoft/rush",
-      "comment": "Allow legacy skip behavior if build cache is configured but disabled. When running in verbose mode, log the type of incremental logic in use.",
+      "comment": "Allow the output preservation incremental strategy if the build cache is configured but disabled. When running in verbose mode, log the incremental strategy that is being used.",
       "type": "none"
     }
   ],
diff --git a/libraries/rush-lib/src/cli/scriptActions/PhasedScriptAction.ts b/libraries/rush-lib/src/cli/scriptActions/PhasedScriptAction.ts
@@ -352,7 +352,7 @@ export class PhasedScriptAction extends BaseScriptAction<IPhasedCommandConfig> {
       }
 
       if (buildCacheConfiguration?.buildCacheEnabled) {
-        terminal.writeVerboseLine(`Incremental mode: build cache`);
+        terminal.writeVerboseLine(`Incremental strategy: cache restoration`);
         new CacheableOperationPlugin({
           allowWarningsInSuccessfulBuild:
             !!this.rushConfiguration.experimentsConfiguration.configuration
@@ -362,15 +362,15 @@ export class PhasedScriptAction extends BaseScriptAction<IPhasedCommandConfig> {
           terminal
         }).apply(this.hooks);
       } else if (!this._disableBuildCache) {
-        terminal.writeVerboseLine(`Incremental mode: legacy skip detection`);
+        terminal.writeVerboseLine(`Incremental strategy: output preservation`);
         // Explicitly disabling the build cache also disables legacy skip detection.
         new LegacySkipPlugin({
           terminal,
           changedProjectsOnly,
           isIncrementalBuildAllowed: this._isIncrementalBuildAllowed
         }).apply(this.hooks);
       } else {
-        terminal.writeVerboseLine(`Incremental mode: disabled`);
+        terminal.writeVerboseLine(`Incremental strategy: none (full rebuild)`);
       }
 
       const projectConfigurations: ReadonlyMap<RushConfigurationProject, RushProjectConfiguration> = this

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`"changes": [`
`3`	`3`	`{`
`4`	`4`	`"packageName": "@microsoft/rush",`
`5`		`- "comment": "Allow legacy skip behavior if build cache is configured but disabled. When running in verbose mode, log the type of incremental logic in use.",`
	`5`	`+ "comment": "Allow the output preservation incremental strategy if the build cache is configured but disabled. When running in verbose mode, log the incremental strategy that is being used.",`
`6`	`6`	`"type": "none"`
`7`	`7`	`}`
`8`	`8`	`],`