Bug fix 3.3/agency loop wrong credentials (arangodb#7071)

hkernbach · mchacki · commit ee1be96bca3d · 2018-10-25T14:16:30.000+02:00
* arangod now exits when used wrong credentials during the startup process

* changelog
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,6 +1,9 @@
 v3.3.20 (XXXX-XX-XX)
 --------------------
 
+* in a cluster environment, the arangod process now exits if wrong credentials
+  are used during the startup process.
+
 * Fixed an AQL bug where the optimize-traversals rule was falsely applied to
   extensions with inline expressions and thereby ignoring them
 
diff --git a/arangod/Agency/AgencyComm.cpp b/arangod/Agency/AgencyComm.cpp
@@ -1221,6 +1221,12 @@ bool AgencyComm::ensureStructureInitialized() {
         LOG_TOPIC(TRACE, Logger::AGENCYCOMM) << "Found an initialized agency";
         break;
       }
+    } else {
+      if (result.httpCode() == 401) {
+        // unauthorized
+        LOG_TOPIC(FATAL, Logger::STARTUP) << "Unauthorized. Wrong credentials.";
+        FATAL_ERROR_EXIT();
+      }
     }
 
     LOG_TOPIC(TRACE, Logger::AGENCYCOMM)

Original file line number	Diff line number	Diff line change
`@@ -1221,6 +1221,12 @@ bool AgencyComm::ensureStructureInitialized() {`
`1221`	`1221`	`LOG_TOPIC(TRACE, Logger::AGENCYCOMM) << "Found an initialized agency";`
`1222`	`1222`	`break;`
`1223`	`1223`	`}`
	`1224`	`+ } else {`
	`1225`	`+ if (result.httpCode() == 401) {`
	`1226`	`+ // unauthorized`
	`1227`	`+ LOG_TOPIC(FATAL, Logger::STARTUP) << "Unauthorized. Wrong credentials.";`
	`1228`	`+ FATAL_ERROR_EXIT();`
	`1229`	`+ }`
`1224`	`1230`	`}`
`1225`	`1231`
`1226`	`1232`	`LOG_TOPIC(TRACE, Logger::AGENCYCOMM)`