8000 Add screenshot tests for `VerticalModeForm` by samer-stripe · Pull Request #11700 · stripe/stripe-android · GitHub
[go: up one dir, main page]
Skip to content

Add screenshot tests for VerticalModeForm #11700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add screenshot tests for VerticalModeForm #11700

wants to merge 1 commit into from

Conversation

samer-stripe
Copy link
Collaborator
@samer-stripe samer-stripe commented Oct 9, 2025 •
edited
Loading

Summary

Add screenshot tests for VerticalModeForm

Motivation

Prevent regression that was fixed in #11672

Testing

  • Added tests
  • Modified tests
  • Manually verified

@samer-stripe
Copy link
Collaborator Author

I manually pulled the branch from #11672, removed the fix commit, then ran this screenshot test. The screenshot was showing the wallets in header. On current master, wallets are not shown per the screenshot in this PR.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Oct 9, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │   1.1 MiB │   1.1 MiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.7 KiB │ 302.7 KiB │  0 B │ 456.5 KiB │ 456.5 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │ -3 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.5 MiB │  11.5 MiB │ -3 B │  25.4 MiB │  25.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20706 │ 20706 │ 0 (+0 -0) 
   types │  6514 │  6514 │ 0 (+0 -0) 
 classes │  5278 │  5278 │ 0 (+0 -0) 
 methods │ 31549 │ 31549 │ 0 (+0 -0) 
  fields │ 18271 │ 18271 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3665 │ 3665 │  0
APK 
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 29.2 KiB │ -4 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.9 KiB │ +1 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼───────────┼──────┼────────────────────────
 55.1 KiB │ -3 B │ 129.1 KiB │  0 B │ (total)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amk-stripe amk-stripe Awaiting requested review from amk-stripe

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samer-stripe
0