8000 Add flag to enable attestation on intent confirmation by toluo-stripe · Pull Request #11682 · stripe/stripe-android · GitHub
[go: up one dir, main page]
Skip to content

Add flag to enable attestation on intent confirmation #11682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add flag to enable attestation on intent confirmation #11682

wants to merge 1 commit into from
+139 −1

Conversation

toluo-stripe
Copy link
Contributor

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Oct 7, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │   4.8 MiB │   4.8 MiB │ +91 B │  10.7 MiB │  10.7 MiB │ +128 B 
     arsc │   2.6 MiB │   2.6 MiB │   0 B │   2.6 MiB │   2.6 MiB │    0 B 
 manifest │   5.8 KiB │   5.8 KiB │   0 B │  30.4 KiB │  30.4 KiB │    0 B 
      res │ 929.9 KiB │ 929.9 KiB │   0 B │   1.5 MiB │   1.5 MiB │    0 B 
   native │   3.5 MiB │   3.5 MiB │   0 B │   8.5 MiB │   8.5 MiB │    0 B 
    asset │   1.6 MiB │   1.6 MiB │  +4 B │   1.6 MiB │   1.6 MiB │   +4 B 
    other │ 198.8 KiB │ 198.8 KiB │  -9 B │ 375.5 KiB │ 375.5 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │  13.7 MiB │  13.7 MiB │ +86 B │  25.3 MiB │  25.3 MiB │ +132 B 

         │         raw          │           unique           
         ├───────┬───────┬──────┼───────┬───────┬────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff       
─────────┼───────┼───────┼──────┼───────┼───────┼────────────
   files │     2 │     2 │    0 │       │       │            
 strings │ 54654 │ 54656 │   +2 │ 50172 │ 50174 │ +2 (+3 -1) 
   types │ 19650 │ 19650 │    0 │ 17498 │ 17498 │  0 (+0 -0) 
 classes │ 14777 │ 14777 │    0 │ 14777 │ 14777 │  0 (+0 -0) 
 methods │ 75638 │ 75638 │    0 │ 72176 │ 72176 │  0 (+0 -0) 
  fields │ 49443 │ 49443 │    0 │ 48116 │ 48116 │  0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6365 │ 6365 │  0
APK 
    compressed     │    uncompressed    │                                           
───────────┬───────┼───────────┬────────┤                                           
 size      │ diff  │ size      │ diff   │ path                                      
───────────┼───────┼───────────┼────────┼───────────────────────────────────────────
   4.3 MiB │ +93 B │   9.4 MiB │ +128 B │ ∆ classes.dex                             
  55.2 KiB │  -7 B │ 122.5 KiB │    0 B │ ∆ META-INF/CERT.SF                        
   9.5 KiB │  +4 B │   9.3 KiB │   +4 B │ ∆ assets/dexopt/baseline.prof             
  51.7 KiB │  -3 B │ 122.5 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                    
 545.3 KiB │  -2 B │   1.2 MiB │    0 B │ ∆ classes2.dex                            
     272 B │  +1 B │     120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
───────────┼───────┼───────────┼────────┼───────────────────────────────────────────
   4.9 MiB │ +86 B │  10.9 MiB │ +132 B │ (total)
DEX 
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   50172 │ 50174 │ +2 (+3 -1) 
  
  + ELEMENTS_MOBILE_ATTEST_ON_INTENT_CONFIRMATION
  + elements_mobile_attest_on_intent_confirmation
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"d22f0ec","r8-mode":"full","version":"8.8.34"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"1213fe3","r8-mode":"full","version":"8.8.34"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@toluo-stripe
0