assert.JSONEq: shortcut if same strings

dolmen · dolmen · commit 2ac68b9707a4 · 2025-05-28T19:08:06.000+02:00
Shortcut in assert.JSONEq once we have validated that 'expected' is
valid JSON, and 'actual' is the exact same string.
diff --git a/assert/assertions.go b/assert/assertions.go
@@ -1853,6 +1853,11 @@ func JSONEq(t TestingT, expected string, actual string, msgAndArgs ...interface{
 		return Fail(t, fmt.Sprintf("Expected value ('%s') is not valid json.\nJSON parsing error: '%s'", expected, err.Error()), msgAndArgs...)
 	}
 
+	// Shortcut if same bytes
+	if actual == expected {
+		return true
+	}
+
 	if err := json.Unmarshal([]byte(actual), &actualJSONAsInterface); err != nil {
 		return Fail(t, fmt.Sprintf("Input ('%s') needs to be valid json.\nJSON parsing error: '%s'", actual, err.Error()), msgAndArgs...)
 	}

Original file line number	Diff line number	Diff line change
`@@ -1853,6 +1853,11 @@ func JSONEq(t TestingT, expected string, actual string, msgAndArgs ...interface{`
`1853`	`1853`	`return Fail(t, fmt.Sprintf("Expected value ('%s') is not valid json.\nJSON parsing error: '%s'", expected, err.Error()), msgAndArgs...)`
`1854`	`1854`	`}`
`1855`	`1855`
	`1856`	`+ // Shortcut if same bytes`
	`1857`	`+ if actual == expected {`
	`1858`	`+ return true`
	`1859`	`+ }`
	`1860`	`+`
`1856`	`1861`	`if err := json.Unmarshal([]byte(actual), &actualJSONAsInterface); err != nil {`
`1857`	`1862`	`return Fail(t, fmt.Sprintf("Input ('%s') needs to be valid json.\nJSON parsing error: '%s'", actual, err.Error()), msgAndArgs...)`
`1858`	`1863`	`}`