Merge pull request symfony#15 from jeskew/feature/document-service-naming-patterns

jeskew · jeskew · commit d1ff64c80ce4 · 2016-02-12T15:56:09.000-08:00
Document service naming patterns
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # CHANGELOG
 
 ## 1.1.0 - 2015-12-10
+
 * Added support for Symfony ~3.0.
 * Fixed deprecation warnings being thrown on Symfony >= 2.6.
 
diff --git a/README.md b/README.md
@@ -81,11 +81,21 @@ services:
 ```
 ## Usage
 
-This bundle exposes an instance of the `Aws\Sdk` object as well as instances of 
-each AWS client object as services to your symfony application. The services
-made available depends on which version of the SDK is installed. To view them, 
-run the following command from your application's root directory:
-
+This bundle exposes an instance of the `Aws\Sdk` object as well as instances of
+each AWS client object as services to your symfony application. They are name 
+`aws.{$namespace}`, where `$namespace` is the namespace of the service client.
+For instance:
+
+Service | Instance Of
+--- | ---
+aws.dynamodb | Aws\DynamoDb\DynamoDbClient
+aws.ec2 | Aws\Ec2\Ec2Client
+aws.s3 | Aws\S3\S3Client
+aws_sdk | Aws\Sdk
+
+The services made available depends on which version of the SDK is installed. To
+view a full list, run the following command from your application's root 
+directory:
 ```
 php app/console container:debug | grep aws
 ```
diff --git a/tests/DependencyInjection/AwsExtensionTest.php b/tests/DependencyInjection/AwsExtensionTest.php
@@ -128,15 +128,7 @@ public function serviceProvider()
     {
         $services = [];
 
-        $awsRoot = dirname((new ReflectionClass(Sdk::class))->getFileName());
-        $manifestFile = implode(DIRECTORY_SEPARATOR, [$awsRoot, 'data', 'manifest.json']);
-
-        $this->assertFileExists($manifestFile);
-
-        $manifest = json_decode(file_get_contents($manifestFile), true);
-        $namespaces = array_column($manifest, 'namespace');
-
-        foreach ($namespaces as $serviceNamespace) {
+        foreach (array_column(\Aws\manifest(), 'namespace') as $serviceNamespace) {
             $clientClass = "Aws\\{$serviceNamespace}\\{$serviceNamespace}Client";
             $services []= [
                 $serviceNamespace,
