10000 Make `Fileuploads._read_chunks` exception-safe · stevee954/server-client-python@3abe4e9 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3abe4e9

Browse files
committed
Make Fileuploads._read_chunks exception-safe
1 parent 95bb0ca commit 3abe4e9

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

tableauserverclient/server/endpoint/fileuploads_endpoint.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,15 @@ def _read_chunks(self, file):
4343
except TypeError:
4444
file_content = file
4545

46-
while True:
47 9810 -
chunked_content = file_content.read(CHUNK_SIZE)
48-
if not chunked_content:
49-
if file_opened:
50-
file_content.close()
51-
break
52-
yield chunked_content
46+
try:
47+
while True:
48+
chunked_content = file_content.read(CHUNK_SIZE)
49+
if not chunked_content:
50+
break
51+
yield chunked_content
52+
finally:
53+
if file_opened:
54+
file_content.close()
5355

5456
def upload(self, file):
5557
upload_id = self.initiate()

0 commit comments

Comments
 (0)
0