Batch action drop down should disable if there are no batch actions. Issue activeadmin#5382

Rohan Sharma · Rohan Sharma · commit c1b9cb618ca5 · 2018-03-21T16:53:34.000+11:00
diff --git a/app/assets/javascripts/active_admin/lib/batch_actions.es6 b/app/assets/javascripts/active_admin/lib/batch_actions.es6
@@ -41,7 +41,7 @@ const onDOMReady = function() {
     }
 
     $(document).on('change', '.paginated_collection :checkbox', function() {
-      if ($(".paginated_collection :checkbox:checked").length) {
+      if ($(".paginated_collection :checkbox:checked").length && $(".dropdown_menu_list").children().length) {
         $(".batch_actions_selector").each(function() { $(this).aaDropdownMenu("enable"); });
       } else {
         $(".batch_actions_selector").each(function() { $(this).aaDropdownMenu("disable"); });

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ const onDOMReady = function() {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`$(document).on('change', '.paginated_collection :checkbox', function() {`
`44`		`- if ($(".paginated_collection :checkbox:checked").length) {`
	`44`	`+ if ($(".paginated_collection :checkbox:checked").length && $(".dropdown_menu_list").children().length) {`
`45`	`45`	`$(".batch_actions_selector").each(function() { $(this).aaDropdownMenu("enable"); });`
`46`	`46`	`} else {`
`47`	`47`	`$(".batch_actions_selector").each(function() { $(this).aaDropdownMenu("disable"); });`