Re-use I18n translations of formtastic ~ Labels (activeadmin#5764)

WaKeMaTTa · javierjulio · commit 8a7aff072e2c · 2019-06-20T10:15:26.000-04:00
* Re-use I18n translations of formtastic ~ Labels
* Undo unnecessary change and add a spec
* Simplify
diff --git a/lib/active_admin/filters/active_filter.rb b/lib/active_admin/filters/active_filter.rb
@@ -66,7 +66,7 @@ def related_class_name
       def filter_label
         return unless filter
 
-        filter[:label]
+        filter[:label] || I18n.t(name, scope: ['formtastic', 'labels'], default: nil)
       end
 
       #@return Ransack::Nodes::Attribute
diff --git a/spec/unit/filters/active_filter_spec.rb b/spec/unit/filters/active_filter_spec.rb
@@ -29,8 +29,20 @@
     expect(subject.values).to eq([post.title])
   end
 
-  it 'should have valid label' do
-    expect(subject.label).to eq("Title equals")
+  describe 'label' do
+    context 'by default' do
+      it 'should have valid label' do
+        expect(subject.label).to eq("Title equals")
+      end
+    end
+
+    context 'with formtastic translations' do
+      it 'should pick up formtastic label' do
+        with_translation formtastic: { labels: { title: 'Supertitle' } } do
+          expect(subject.label).to eq("Supertitle equals")
+        end
+      end
+    end
   end
 
   it 'should pick predicate name translation' do
