[Bugfix] Add minor amendments for backwards compatibility

lindyhopchris · lindyhopchris · commit 96965adc9716 · 2017-07-24T12:06:39.000+01:00
Test response helper needs to not type-hint response because
the JSON response class does not extend the Illuminate response.

The error repository from the inbound request API needs to be
bound in the container for backwards compatibility with classes
that were resolving it via constructor injection.
diff --git a/src/ServiceProvider.php b/src/ServiceProvider.php
@@ -24,6 +24,7 @@
 use CloudCreativity\JsonApi\Contracts\Object\DocumentInterface;
 use CloudCreativity\JsonApi\Contracts\Object\RelationshipInterface;
 use CloudCreativity\JsonApi\Contracts\Object\ResourceObjectInterface;
+use CloudCreativity\JsonApi\Contracts\Repositories\ErrorRepositoryInterface;
 use CloudCreativity\JsonApi\Contracts\Store\StoreInterface;
 use CloudCreativity\JsonApi\Exceptions\RuntimeException;
 use CloudCreativity\LaravelJsonApi\Api\Repository;
@@ -199,7 +200,7 @@ protected function bindRequestInterpreter()
     }
 
     /**
-     * Bind the inbound request services so they can be type-hinted in controllers.
+     * Bind the inbound request services so they can be type-hinted in controllers and authorizers.
      *
      * @return void
      */
@@ -209,6 +210,10 @@ protected function bindInboundRequest()
             return json_api()->getStore();
         });
 
+        $this->app->bind(ErrorRepositoryInterface::class, function (Application $app) {
+            return json_api()->getErrors();
+        });
+
         $this->app->bind(DocumentInterface::class, function () {
             if (!$document = json_api_request()->getDocument()) {
                 throw new RuntimeException('No request document on inbound JSON API request.');
diff --git a/src/Testing/TestResponse.php b/src/Testing/TestResponse.php
@@ -30,7 +30,7 @@ class TestResponse extends BaseTestResponse
      * @param Response $response
      * @param string|null $expectedResourceType
      */
-    public function __construct(Response $response, $expectedResourceType = null)
+    public function __construct($response, $expectedResourceType = null)
     {
         parent::__construct($response);
         $this->expectedResourceType = $expectedResourceType;

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class TestResponse extends BaseTestResponse`
`30`	`30`	`* @param Response $response`
`31`	`31`	`* @param string\|null $expectedResourceType`
`32`	`32`	`*/`
`33`		`- public function __construct(Response $response, $expectedResourceType = null)`
	`33`	`+ public function __construct($response, $expectedResourceType = null)`
`34`	`34`	`{`
`35`	`35`	`parent::__construct($response);`
`36`	`36`	`$this->expectedResourceType = $expectedResourceType;`