10000 Merge pull request #135 from oliversalzburg/fix/report · stacktracejs/stacktrace.js@2053cd7 · GitHub
[go: up one dir, main page]
Skip to content

Commit 2053cd7

Browse files
oliversalzburgoliversalzburg
committed
Merge pull request #135 from oliversalzburg/fix/report
Convert reports to JSON
2 parents 021e11e + 269ea34 commit 2053cd7

11 files changed

+14
-9
lines changed

‎.jshintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
dist/*

‎.jshintrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"JASMINE": true,
4545
"JASMINE_ADAPTER": true,
4646
"matchers": true,
47-
"priv": true
47+
"priv": true,
48+
"JSON": true
4849
}
4950
}

‎dist/stacktrace-with-polyfills.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/stacktrace-with-polyfills.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/stacktrace.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@
178178
};
179179
req.open('post', url);
180180
req.setRequestHeader('Content-Type', 'application/json');
181-
req.send({stack: stackframes});
181+
req.send(JSON.stringify({stack: stackframes}));
182182
});
183183
}
184184
};

‎dist/stacktrace.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/stacktrace.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎gulpfile.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ var uglify = require('gulp-uglify');
1010

1111
var polyfills = [
1212
'./node_modules/es6-promise/dist/es6-promise.js',
13+
'./node_modules/json3/lib/json3.js',
1314
'./polyfills.js'
1415
];
1516
var dependencies = [

‎package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
"gulp-uglify": "^1.4.1",
3838
"jasmine-node": "~1.14",
3939
"jasmine-sinon": "^0.4.0",
40+
"json3": "^3.3.2",
4041
"karma": "^0.13.9",
4142
"karma-chrome-launcher": "^0.2.0",
4243
"karma-coverage": "^0.5.2",

‎spec/stacktrace-spec.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,8 @@ describe('StackTrace', function () {
230230
});
231231
waits(100);
232232
runs(function () {
233-
expect(server.requests[0].requestBody).toEqual({stack: stackframes});
233+
var expectedResponse = JSON.stringify({stack: stackframes});
234+
expect(server.requests[0].requestBody).toEqual(expectedResponse);
234235
expect(server.requests[0].url).toEqual(url);
235236
expect(callback).toHaveBeenCalledWith('OK');
236237
expect(errback).not.toHaveBeenCalled();

0 commit comments

Comments
 (0)
0