Matching the last sourceMappingURL in the file. #50
Conversation
Currently `_findSourceMappingURL` returns the first `sourceMappingURL` uri it finds, but we really want is the last match.
| return m[1]; | ||
| } else { | ||
| throw new Error('sourceMappingURL not found'); | ||
| var allMatches = source.match(_reSourceMapping); |
There was a problem hiding this comment.
Note:
When using a global (g) RegExp with match it returns an array with all the matched ocurrences.
But when using it with exec it seems to ignore the global flag and returns the match groups.
|
Hi @fabiomcosta, thank you for your PR, and sorry for the late follow-up. I just happened to get to #53 before this one which solves the same issue and merged it, so this isn't necessary anymore. I think this solution is just as good as the other one, though, so thank you for a high-quality contribution. A fix for the issue in question has been released in stacktrace-gps v3.0.2 today. Thanks again. |
|
Hi @eriwen thank you for your kind response and for this great work that you provide for us all. |
|
@fabiomcosta thanks for the kind words :) |
Currently
_findSourceMappingURLreturns the firstsourceMappingURLuri it finds, but we really want is the last match.
Motivation and Context
I found because on one of my project's bundle in development there is one dependency that is (for some reason) including a
sourceMappingURLcomment and that uri is being incorrectly returned instead of the bundle's source map.How Has This Been Tested?
gulp testTypes of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc stacktrace-gps.jspasses without errorsnpm testpasses without errors