Ensure the parent process is always killed

greg0ire · greg0ire · commit 94d41825fd5b · 2019-04-06T12:12:12.000+02:00
If you try to run the test suite but do not have a redis instance
running, the parent process that was supposed to be killed will never be
as the thing being thrown is not an exception.
This results in the test suite hanging forever at the end.
In this patch, the exception is thrown again, and then caught in the trait, and
the parent gets killed as it should.
diff --git a/src/Symfony/Component/Lock/Tests/Store/BlockingStoreTestTrait.php b/src/Symfony/Component/Lock/Tests/Store/BlockingStoreTestTrait.php
@@ -74,8 +74,8 @@ public function testBlockingLocks()
             // Block SIGHUP signal
             pcntl_sigprocmask(SIG_BLOCK, [SIGHUP]);
 
-            $store = $this->getStore();
             try {
+                $store = $this->getStore();
                 $store->save($key);
                 // send the ready signal to the parent
                 posix_kill($parentPID, SIGHUP);
@@ -87,7 +87,8 @@ public function testBlockingLocks()
                 usleep($clockDelay);
                 $store->delete($key);
                 exit(0);
-            } catch (\Exception $e) {
+            } catch (\Throwable $e) {
+                posix_kill($parentPID, SIGHUP);
                 exit(1);
             }
         }
