bug symfony#25662 Dumper shouldn't use html format for phpdbg / cli-server (jhoff)

nicolas-grekas · nicolas-grekas · commit 8e54591f2436 · 2018-01-03T11:33:07.000+01:00
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes symfony#25662). Discussion ---------- Dumper shouldn't use html format for phpdbg / cli-server | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This may not be the lowest branch that this fix applies to. Prevents the dumper from outputting in html format when using phpdbg. Commits ------- e2b6091 Dumper shouldn't use html format for phpdbg
diff --git a/src/Symfony/Component/VarDumper/VarDumper.php b/src/Symfony/Component/VarDumper/VarDumper.php
@@ -29,7 +29,7 @@ public static function dump($var)
     {
         if (null === self::$handler) {
             $cloner = new VarCloner();
-            $dumper = 'cli' === PHP_SAPI ? new CliDumper() : new HtmlDumper();
+            $dumper = in_array(PHP_SAPI, array('cli', 'phpdbg')) ? new CliDumper() : new HtmlDumper();
             self::$handler = function ($var) use ($cloner, $dumper) {
                 $dumper->dump($cloner->cloneVar($var));
             };

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public static function dump($var)`
`29`	`29`	`{`
`30`	`30`	`if (null === self::$handler) {`
`31`	`31`	`$cloner = new VarCloner();`
`32`		`- $dumper = 'cli' === PHP_SAPI ? new CliDumper() : new HtmlDumper();`
	`32`	`+ $dumper = in_array(PHP_SAPI, array('cli', 'phpdbg')) ? new CliDumper() : new HtmlDumper();`
`33`	`33`	`self::$handler = function ($var) use ($cloner, $dumper) {`
`34`	`34`	`$dumper->dump($cloner->cloneVar($var));`
`35`	`35`	`};`