pythongh-127740: Improve code, consolidate two variables into one

srinivasreddy · srinivasreddy · commit f3bfe8537c59 · 2024-12-09T14:13:34.000+05:30
diff --git a/Objects/bytesobject.c b/Objects/bytesobject.c
@@ -2516,10 +2516,9 @@ _PyBytes_FromHex(PyObject *string, int use_bytearray)
     }
 
     assert(PyUnicode_KIND(string) == PyUnicode_1BYTE_KIND);
-
-    const Py_UCS1 *s = PyUnicode_1BYTE_DATA(string);
+    str = PyUnicode_1BYTE_DATA(string);
     for (Py_ssize_t i = 0; i < hexlen; i++) {
-        if (!Py_ISSPACE(s[i])) {
+        if (!Py_ISSPACE(str[i])) {
             real_len++;
         }
     }
@@ -2529,7 +2528,6 @@ _PyBytes_FromHex(PyObject *string, int use_bytearray)
         _PyBytesWriter_Dealloc(&writer);
         return NULL;
     }
-    str = PyUnicode_1BYTE_DATA(string);
 
     /* This overestimates if there are spaces */
     buf = _PyBytesWriter_Alloc(&writer, hexlen / 2);

Original file line number	Diff line number	Diff line change
`@@ -2516,10 +2516,9 @@ _PyBytes_FromHex(PyObject *string, int use_bytearray)`
`2516`	`2516`	`}`
`2517`	`2517`
`2518`	`2518`	`assert(PyUnicode_KIND(string) == PyUnicode_1BYTE_KIND);`
`2519`		`-`
`2520`		`- const Py_UCS1 *s = PyUnicode_1BYTE_DATA(string);`
	`2519`	`+ str = PyUnicode_1BYTE_DATA(string);`
`2521`	`2520`	`for (Py_ssize_t i = 0; i < hexlen; i++) {`
`2522`		`- if (!Py_ISSPACE(s[i])) {`
	`2521`	`+ if (!Py_ISSPACE(str[i])) {`
`2523`	`2522`	`real_len++;`
`2524`	`2523`	`}`
`2525`	`2524`	`}`
`@@ -2529,7 +2528,6 @@ _PyBytes_FromHex(PyObject *string, int use_bytearray)`
`2529`	`2528`	`_PyBytesWriter_Dealloc(&writer);`
`2530`	`2529`	`return NULL;`
`2531`	`2530`	`}`
`2532`		`- str = PyUnicode_1BYTE_DATA(string);`
`2533`	`2531`
`2534`	`2532`	`/* This overestimates if there are spaces */`
`2535`	`2533`	`buf = _PyBytesWriter_Alloc(&writer, hexlen / 2);`