install from source link

jlwalke2 · jlwalke2 · commit 21408b417de7 · 2021-05-06T12:26:07.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 Unreleased
 ----------
- -
+**Bugfixes**
+ - SSL warnings no longer repeatedly raised when `verify_ssl=False` but `CAS_CLIENT_SSL_CA_LIST` is specified.
+ 
+**Improvements**
+ - All `delete_*()` service methods return `None` instead of empty string.
  
 v1.5.7 (2021-05-04)
 -------------------
diff --git a/src/sasctl/_services/service.py b/src/sasctl/_services/service.py
@@ -320,7 +320,12 @@ def delete_item(cls, item):
                 item = item['id']
 
             if cls.is_uuid(item):
-                return cls.delete(path + '/{id}'.format(id=item))
+                response = cls.delete(path + '/{id}'.format(id=item))
+                # Response generally seems to be an empty string.  If so, just return None
+                # BUT, if the service provides an actual response, return it.
+                if response:
+                    return response
+                return
             raise ValueError("Unrecognized id '%s'" % item)
 
         # Pull object name from path if unspecified (many paths end in
diff --git a/src/sasctl/core.py b/src/sasctl/core.py
@@ -303,11 +303,11 @@ def is_ipaddress(hst):
 
                 self.mount('https://', adapter)
 
-            else:
-                # Every request will generate an InsecureRequestWarning
-                from urllib3.exceptions import InsecureRequestWarning
-
-                warnings.simplefilter('default', InsecureRequestWarning)
+        # If we're skipping SSL verification, urllib3 will raise InsecureRequestWarnings on
+        # every request.  Insert a warning filter so these warnings only appear on the first request.
+        if not verify_ssl:
+            from urllib3.exceptions import InsecureRequestWarning
+            warnings.simplefilter('default', InsecureRequestWarning)
 
         self.filters = DEFAULT_FILTERS
 
