[DomCrawler] minor performance improvement

dunglas · nicolas-grekas · commit eead3012246f · 2018-03-14T17:32:56.000+01:00
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -1081,8 +1081,9 @@ protected function sibling($node, $siblingDir = 'nextSibling')
     {
         $nodes = array();
 
+        $currentNode = $this->getNode(0);
         do {
-            if ($node !== $this->getNode(0) && 1 === $node->nodeType) {
+            if ($node !== $currentNode && XML_ELEMENT_NODE === $node->nodeType) {
                 $nodes[] = $node;
             }
         } while ($node = $node->$siblingDir);

Original file line number	Diff line number	Diff line change
`@@ -1081,8 +1081,9 @@ protected function sibling($node, $siblingDir = 'nextSibling')`
`1081`	`1081`	`{`
`1082`	`1082`	`$nodes = array();`
`1083`	`1083`
	`1084`	`+ $currentNode = $this->getNode(0);`
`1084`	`1085`	`do {`
`1085`		`- if ($node !== $this->getNode(0) && 1 === $node->nodeType) {`
	`1086`	`+ if ($node !== $currentNode && XML_ELEMENT_NODE === $node->nodeType) {`
`1086`	`1087`	`$nodes[] = $node;`
`1087`	`1088`	`}`
`1088`	`1089`	`} while ($node = $node->$siblingDir);`