minor symfony#26467 Add UsernameNotFoundException declaration to refreshUser(). (umulmrum)

fabpot · fabpot · commit e0f79f69be22 · 2018-03-10T12:27:29.000-06:00
This PR was squashed before being merged into the 4.1-dev branch (closes symfony#26467). Discussion ---------- Add UsernameNotFoundException declaration to refreshUser(). | Q | A | ------------- | --- | Branch? | master | Bug fix? | maybe | New feature? | maybe | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Symfony\Component\Security\Core\User\UserProviderInterface::refreshUser() does not declare that implementations may throw a UsernameNotFoundException, although a) it makes sense, as the user could have been deleted since the last load, and b) the ContextListener already handles the UsernameNotFoundException. So it looks like someone thought of this, but simply forgot the annotation. Unsure if this is a bugfix or a feature, but as it doesn't change executed code, master should be soon enough. Commits ------- f7a0c46 Add UsernameNotFoundException declaration to refreshUser().
diff --git a/src/Symfony/Component/Security/Core/User/UserProviderInterface.php b/src/Symfony/Component/Security/Core/User/UserProviderInterface.php
@@ -57,7 +57,8 @@ public function loadUserByUsername($username);
      *
      * @return UserInterface
      *
-     * @throws UnsupportedUserException if the user is not supported
+     * @throws UnsupportedUserException  if the user is not supported
+     * @throws UsernameNotFoundException if the user is not found
      */
     public function refreshUser(UserInterface $user);
 

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,8 @@ public function loadUserByUsername($username);`
`57`	`57`	`*`
`58`	`58`	`* @return UserInterface`
`59`	`59`	`*`
`60`		`- * @throws UnsupportedUserException if the user is not supported`
	`60`	`+ * @throws UnsupportedUserException if the user is not supported`
	`61`	`+ * @throws UsernameNotFoundException if the user is not found`
`61`	`62`	`*/`
`62`	`63`	`public function refreshUser(UserInterface $user);`
`63`	`64`