minor symfony#20523 [Serializer] Improve test coverage of the MaxDepth annotation (dunglas)

fabpot · fabpot · commit a813cb7f76b6 · 2016-11-15T15:46:31.000-05:00
This PR was merged into the 3.1 branch. Discussion ---------- [Serializer] Improve test coverage of the MaxDepth annotation | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 5311696 [Serializer] Improve test coverage of the MaxDepth annotation
diff --git a/src/Symfony/Component/Serializer/Tests/Annotation/MaxDepthTest.php b/src/Symfony/Component/Serializer/Tests/Annotation/MaxDepthTest.php
@@ -18,6 +18,22 @@
  */
 class MaxDepthTest extends \PHPUnit_Framework_TestCase
 {
+    /**
+     * @expectedException \Symfony\Component\Serializer\Exception\InvalidArgumentException
+     */
+    public function testNotSetMaxDepthParameter()
+    {
+        new MaxDepth(array());
+    }
+
+    /**
+     * @expectedException \Symfony\Component\Serializer\Exception\InvalidArgumentException
+     */
+    public function testEmptyMaxDepthParameter()
+    {
+        new MaxDepth(array('value' => ''));
+    }
+
     /**
      * @expectedException \Symfony\Component\Serializer\Exception\InvalidArgumentException
      */
@@ -28,9 +44,7 @@ public function testNotAnIntMaxDepthParameter()
 
     public function testMaxDepthParameters()
     {
-        $validData = 3;
-
-        $groups = new MaxDepth(array('value' => 3));
-        $this->assertEquals($validData, $groups->getMaxDepth());
+        $maxDepth = new MaxDepth(array('value' => 3));
+        $this->assertEquals(3, $maxDepth->getMaxDepth());
     }
 }
