minor symfony#12058 [Doctrine][DependencyInjection] Make a test less fragile. (AlphaStream)

fabpot · fabpot · commit 2ecbf87aa3ca · 2014-09-27T09:50:52.000+02:00
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#12058). Discussion ---------- [Doctrine][DependencyInjection] Make a test less fragile. The test checks that a few items are ordered according to the value of their 'priority' attribute. However, a few of the items have the same value of this attribute. RegisterEventListenersAndSubscribersPass doesn't use a stable sorting, yet the test asserts that items that are 'equal' shall go in the original order. Modified so that the order of the original items is not checked. | Q | A | ------------- | --- | Bug fix? | [no] | New feature? | [no] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes] | Fixed tickets | [none] | License | MIT | Doc PR | [none] Commits ------- f1ae970 Make Doctrine's dependency injection test less fragile.
diff --git a/src/Symfony/Bridge/Doctrine/Tests/DependencyInjection/CompilerPass/RegisterEventListenersAndSubscribersPassTest.php b/src/Symfony/Bridge/Doctrine/Tests/DependencyInjection/CompilerPass/RegisterEventListenersAndSubscribersPassTest.php
@@ -139,7 +139,11 @@ public function testProcessEventSubscribersWithPriorities()
         ;
 
         $this->process($container);
-        $this->assertEquals(array('c', 'd', 'e', 'b', 'a'), $this->getServiceOrder($container, 'addEventSubscriber'));
+        $serviceOrder = $this->getServiceOrder($container, 'addEventSubscriber');
+        $unordered = array_splice($serviceOrder, 0, 3);
+        sort($unordered);
+        $this->assertEquals(array('c', 'd', 'e'), $unordered);
+        $this->assertEquals(array('b', 'a'), $serviceOrder);
     }
 
     private function process(ContainerBuilder $container)

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,11 @@ public function testProcessEventSubscribersWithPriorities()`
`139`	`139`	`;`
`140`	`140`
`141`	`141`	`$this->process($container);`
`142`		`- $this->assertEquals(array('c', 'd', 'e', 'b', 'a'), $this->getServiceOrder($container, 'addEventSubscriber'));`
	`142`	`+ $serviceOrder = $this->getServiceOrder($container, 'addEventSubscriber');`
	`143`	`+ $unordered = array_splice($serviceOrder, 0, 3);`
	`144`	`+ sort($unordered);`
	`145`	`+ $this->assertEquals(array('c', 'd', 'e'), $unordered);`
	`146`	`+ $this->assertEquals(array('b', 'a'), $serviceOrder);`
`143`	`147`	`}`
`144`	`148`
`145`	`149`	`private function process(ContainerBuilder $container)`