[JENKINS-38935] Should add aliases on base plugin methods as 'start'

lanwen · lanwen · commit b9169402c380 · 2016-10-12T23:09:51.000+03:00
diff --git a/src/main/java/org/jenkinsci/plugins/github/GitHubPlugin.java b/src/main/java/org/jenkinsci/plugins/github/GitHubPlugin.java
@@ -23,8 +23,6 @@ public class GitHubPlugin extends Plugin {
     /**
      * Launched before plugin starts
      * Adds alias for {@link GitHubPlugin} to simplify resulting xml.
-     * Expected milestone: @Initializer(before = PLUGINS_STARTED)
-     * * @see #initializers()
      */
     public static void addXStreamAliases() {
         Migrator.enableCompatibilityAliases();
@@ -35,19 +33,23 @@ public static void addXStreamAliases() {
      * Launches migration after plugin already initialized.
      * Expected milestone: @Initializer(after = PLUGINS_PREPARED)
      *
-     * @see #initializers()
+     * @see #migrator()
      */
     public static void runMigrator() throws Exception {
         new Migrator().migrate();
     }
 
+    @Override
+    public void start() throws Exception {
+        addXStreamAliases();
+    }
+
     /**
      * We need ensure that migrator will run after xstream aliases will be added.
      * Unclear how reactor will sort single methods, so bundle in one step.
      */
     @Initializer(after = PLUGINS_PREPARED, before = PLUGINS_STARTED)
-    public static void initializers() throws Exception {
-        addXStreamAliases();
+    public static void migrator() throws Exception {
         runMigrator();
     }
 
