8000 Cleanup initializers (#147) · srbala/github-plugin@a9b9b28 · GitHub
[go: up one dir, main page]

Skip to content

Commit a9b9b28

Browse files
KostyaShalanwen
authored andcommitted
Cleanup initializers (jenkinsci#147)
1 parent ec4bf69 commit a9b9b28

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

src/main/java/org/jenkinsci/plugins/github/GitHubPlugin.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,9 @@ public static void addXStreamAliases() {
3131

3232
/**
3333
* Launches migration after plugin already initialized.
34-
* Expected milestone: @Initializer(after = PLUGINS_PREPARED)
35-
*
36-
* @see #migrator()
34+
* We need ensure that migrator will run after xstream aliases will be added.
3735
*/
36+
@Initializer(after = PLUGINS_PREPARED, before = PLUGINS_STARTED)
3837
public static void runMigrator() throws Exception {
3938
new Migrator().migrate();
4039
}
@@ -44,15 +43,6 @@ public void start() throws Exception {
4443
addXStreamAliases();
4544
}
4645

47-
/**
48-
* We need ensure that migrator will run after xstream aliases will be added.
49-
* Unclear how reactor will sort single methods, so bundle in one step.
50-
*/
51-
@Initializer(after = PLUGINS_PREPARED, before = PLUGINS_STARTED)
52-
public static void migrator() throws Exception {
53-
runMigrator();
54-
}
55-
5646
/**
5747
* Shortcut method for getting instance of {@link GitHubPluginConfig}.
5848
*

0 commit comments

Comments
 (0)
0