Privacy plugin: more accurate pattern to capture external links #8542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR. Please provide a minimal reproduction, so we can observe the errors this PR is trying to fix + decide whether it is worth integrating. Please note that this project is now in maintenance mode. |
Contributor
Author
|
Here you are : |
Owner
|
Thanks for providing the reproduction, looks good! |
Owner
|
Another fix was necessary to make protocol-relative URLs work. I'm not sure why this worked on your machine, but requests failed with being able to fetch the URL. Fixed in 79ba428. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more accurate pattern to capture external links in privacy plugin.
Fix is two-fold:
http//x.y.z/