8000 bug: version selector does not work with recent change (insiders) · Issue #2929 · squidfunk/mkdocs-material · GitHub
[go: up one dir, main page]

Skip to content

bug: version selector does not work with recent change (insiders) #2929

@dmccaffery

Description

@dmccaffery

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

The following change breaks the version selector as the URL for versions.json now resolves within the version directory /v1.0.0/versions.json instead of the root of the host /versions.json.

https://github.com/squidfunk/mkdocs-material-insiders/blame/f80b15d5805d37428307cf7f9eebf1ef3275b47a/src/assets/javascripts/_/index.ts#L105

Expected behaviour

The version selector should work as the versions.json should be retrieved from the root instead of the version-specific path.

Actual behaviour

The version selector does not work as the attempt to retrieve the versions.json file fails.

Steps to reproduce

  1. mike deploy v1.0.0
  2. mike deploy v2.0.0
  3. mike serve

Package versions

  • Python: 3.9.6
  • MkDocs: mkdocs, version 1.2.2
  • Material: 7.2.3+insiders.2.13.0

Configuration

extra:
  version:
    provider: mike

System information

  • Operating system: macOS Monterey Beta 4
  • Browser: Safari

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue reports a bugresolvedIssue is resolved, yet unreleased if open

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0