fix: Return None when retrieving the oid for an external table #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos
Fixes #304
I'm not sure if this is the best way to solve this. I thought about checking the specific
exception
class, but got stuck on two issues:psycopg2
andredshift-connector
.Another approach would be to check the the class name. Something like:
Or check the exception text:
But these could still be too generic. The suggested approach confirms if the table is indeed external through the metadata -- counterpart is that it executes another query.
Open to suggestions here. :) Once we define on next steps I can look at adding tests/etc.