8000 Add redshift_connector example to docs by Brooke-white · Pull Request #233 · sqlalchemy-redshift/sqlalchemy-redshift · GitHub
[go: up one dir, main page]
Skip to content

Add redshift_connector example to docs #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add redshift_connector example to docs #233

wants to merge 5 commits into from

Conversation

Brooke-white
Copy link
Contributor

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst

Adds redshift_connector as a supported database driver in README. Provide usage example.

@jklukas
Copy link
Member
jklukas commented Oct 5, 2021

Docs changes look good. Is redshift_connector python 3 only? I'm not sure whether doctests have any facility to make tests conditional, since the 2.7 version is failing without having redshift_connector installed. I'd be fine with turning off doctests completely for 2.7 if that ends up being easier.

@Brooke-white
Copy link
Contributor Author

redshift_connector is Python3 only

I found this for conditionally skipping tests, though I have run into issues trying to build docs locally, so haven't been able to give it a shot

@graingert
Copy link
Member
graingert commented Oct 6, 2021 •
edited
Loading

Docs changes look good. Is redshift_connector python 3 only? I'm not sure whether doctests have any facility to make tests conditional, since the 2.7 version is failing without having redshift_connector installed. I'd be fine with turning off doctests completely for 2.7 if that ends up being easier.

lets just make one last release with py2.7 support and then strip py2.7 completely

it's also time to remove the "redshift_sqlalchemy compatibility package"

@jklukas
Copy link
Member
jklukas commented Nov 3, 2021

This should be unblocked now that we're python 3 only

jklukas
jklukas reviewed Nov 3, 2021
View reviewed changes
CHANGES.rst
@@ -6,6 +6,7 @@
- Support GEOMETRY, SUPER Redshift datatypes
(`Pull #235 <https://github.com/sqlalchemy-redshift/sqlalchemy-redshift/pull/235>`_)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change note is needed here, since it doesn't affect behavior.

jklukas
jklukas approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member
@jklukas jklukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed up some conflicts, and this should be good to go as long as tests finish successfully.

@jklukas
Copy link
Member
jklukas commented Nov 3, 2021

The test on python 3.5 is failing due to not having redshift_connector installed. I think we can go ahead and include redshift_connector in the dependencies for py35-sa13 in tox.ini to get around this.

@Brooke-white Brooke-white marked this pull request as draft November 5, 2021 17:10
@Brooke-white
Copy link
Contributor Author

I've realized python 3.5 support for redshift_connector seems to be broken due to an incompatible dependency -- setting this to a draft while I investigate next steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklukas jklukas jklukas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brooke-white @jklukas @graingert
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0