-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP. Support Amazon S3 FileSystem. #216
base: master
Are you sure you want to change the base?
Conversation
why did we not merge this pr? |
I have not managed to make integration tests to work (in time). Will continue working on this during next available timeslot. ;) |
understand. understand. Looking forward to it. Is it during a hack day interval? We'd like to understand if we can have it out in our next release cycle. |
first of all, thanks for the patch: dbeam is used in production with S3 targets at one of my large client. Is there anything I can help with to get it merged? adding tests or docuemtation? thx /cc @rulle-io |
Sorry, I got involved in other things and forgot about it. :) I will create a proper PR in coming days. |
I also forgot about this. You rock Ruslan. Looking forward to include this in our next release |
I can do the e2e tests, no issues. Do we want to use a real S3 bucket or just a mocked S3 service? If you want the real thing, we might need to set up access/secret keys for the CI. |
Just a mocked S3 service, please. |
How about this: rulle-io@6647bb8 ? |
Requires more testing. Works locally in IDEA.
Related to #209 .