[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP. Support Amazon S3 FileSystem. #216

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rulle-io
Copy link
Contributor
@rulle-io rulle-io commented Jun 8, 2020

Requires more testing. Works locally in IDEA.
Related to #209 .

@rulle-io rulle-io closed this Jun 9, 2020
@rulle-io rulle-io changed the title Support Amazon S3 FileSystem. WIP. Support Amazon S3 FileSystem. Jun 9, 2020
@xuanpan
Copy link
xuanpan commented Jun 11, 2020

why did we not merge this pr?

@rulle-io
Copy link
Contributor Author

I have not managed to make integration tests to work (in time). Will continue working on this during next available timeslot. ;)

@xuanpan
Copy link
xuanpan commented Jun 14, 2020

understand. understand. Looking forward to it. Is it during a hack day interval? We'd like to understand if we can have it out in our next release cycle.

@tfoldi
Copy link
Contributor
tfoldi commented Sep 8, 2020

first of all, thanks for the patch: dbeam is used in production with S3 targets at one of my large client. Is there anything I can help with to get it merged? adding tests or docuemtation? thx /cc @rulle-io

@rulle-io
Copy link
Contributor Author
rulle-io commented Sep 8, 2020

Sorry, I got involved in other things and forgot about it. :) I will create a proper PR in coming days.
Technically, I wanted to add a e2e test to see that iy actually works.
If you can add such one, it would simplify things a lot. @tfoldi

@rulle-io rulle-io reopened this Sep 8, 2020
@xuanpan
Copy link
xuanpan commented Sep 8, 2020

I also forgot about this. You rock Ruslan. Looking forward to include this in our next release

@tfoldi
Copy link
Contributor
tfoldi commented Sep 10, 2020

Technically, I wanted to add a e2e test to see that iy actually works.
If you can add such one, it would simplify things a lot. @tfoldi

I can do the e2e tests, no issues. Do we want to use a real S3 bucket or just a mocked S3 service? If you want the real thing, we might need to set up access/secret keys for the CI.

@rulle-io
Copy link
Contributor Author

Just a mocked S3 service, please.

@tfoldi
Copy link
Contributor
tfoldi commented Sep 11, 2020

How about this: rulle-io@6647bb8 ?

@rulle-io rulle-io marked this pull request as draft August 30, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants