From 33f824fbe360ba9488d483ed3f6387cdc217ba67 Mon Sep 17 00:00:00 2001 From: Johannes Grumboeck Date: Fri, 5 Jan 2024 09:16:11 +0100 Subject: [PATCH 1/2] feat(ecs): Add support for ECS deployment circuit breaker --- packages/ecs/src/ecs.help.ts | 1 + .../configure/serverGroupCommandBuilder.service.js | 1 + .../advancedSettings/advancedSettings.component.html | 10 ++++++++++ 3 files changed, 12 insertions(+) diff --git a/packages/ecs/src/ecs.help.ts b/packages/ecs/src/ecs.help.ts index b6badf45054..c411e60bd43 100644 --- a/packages/ecs/src/ecs.help.ts +++ b/packages/ecs/src/ecs.help.ts @@ -36,6 +36,7 @@ const helpContents: { [key: string]: string } = { 'ecs.placementStrategy': '

The strategy the container scheduler will be using. See AWS documentation for more details.

You should at least balance across availability zones

Custom placement strategies have not been implemented yet.

', 'ecs.platformVersion': '

Defaults to the latest platform version.

', + 'ecs.enableDeploymentCircuitBreaker': '

Enable circuit breaker for the ECS service.

', 'ecs.capacity.copySourceScalingPoliciesAndActions': '

Copy Application Autoscaling policies and their associated alarms from the previous ECS service.

', 'ecs.launchtype': '

Launch service tasks on your own EC2 instances or on Fargate.

', diff --git a/packages/ecs/src/serverGroup/configure/serverGroupCommandBuilder.service.js b/packages/ecs/src/serverGroup/configure/serverGroupCommandBuilder.service.js index b77db7dea66..202fa3b33b3 100644 --- a/packages/ecs/src/serverGroup/configure/serverGroupCommandBuilder.service.js +++ b/packages/ecs/src/serverGroup/configure/serverGroupCommandBuilder.service.js @@ -151,6 +151,7 @@ angular copySourceScalingPoliciesAndActions: true, preferSourceCapacity: true, useSourceCapacity: true, + enableDeploymentCircuitBreaker: false, viewState: { useAllImageSelection: false, useSimpleCapacity: true, diff --git a/packages/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html b/packages/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html index 4e0d26426f8..fe1b5af7b3b 100644 --- a/packages/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html +++ b/packages/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html @@ -78,6 +78,16 @@ +
+
+ + +
+
+
Placement Strategy From f56434533cf4ffed668f2d9ef4b30ef0a98d32f8 Mon Sep 17 00:00:00 2001 From: Johannes Grumboeck Date: Wed, 17 Jan 2024 18:14:10 +0100 Subject: [PATCH 2/2] chore(ecs): rearrange checkbox for deployment circuit breaker to better align with other form elements --- .../advancedSettings/advancedSettings.component.html | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html b/packages/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html index fe1b5af7b3b..70f8f0b7ea7 100644 --- a/packages/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html +++ b/packages/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html @@ -79,13 +79,13 @@
-
- +
+ Enable Deployment Circuit Breaker
+
+ +