8000 Replace ``None`` filename with ``''`` in ``Sphinx.add_js_file()`` (#1… · sphinx-doc/sphinx@13d2899 · GitHub
[go: up one dir, main page]

Skip to content

Commit 13d2899

Browse files
mitya57AA-Turner
andauthored
Replace None filename with '' in Sphinx.add_js_file() (#13402)
Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
1 parent b151aa1 commit 13d2899

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

CHANGES.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ Bugs fixed
1717
----------
1818

1919
* #13392: Fix argument type for ``jieba.load_userdict()``.
20+
* #13402: Ensure inline ``<script>`` tags are written exactly once.
2021

2122
Testing
2223
-------

sphinx/application.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1507,6 +1507,7 @@ def add_js_file(
15071507
elif loading_method == 'defer':
15081508
kwargs['defer'] = 'defer'
15091509

1510+
filename = filename or ''
15101511
self.registry.add_js_file(filename, priority=priority, **kwargs)
15111512
with contextlib.suppress(AttributeError):
15121513
self.builder.add_js_file( # type: ignore[attr-defined]

0 commit comments

Comments
 (0)
0