fix test to correctly use assumption of no comments in relationships

lumjjb · armintaenzertng · commit 32e3d2d4b8ba · 2023-08-17T16:24:58.000+02:00
Signed-off-by: Brandon Lum &lt;lumjjb@gmail.com&gt;
diff --git a/src/spdx_tools/spdx/parser/jsonlikedict/relationship_parser.py b/src/spdx_tools/spdx/parser/jsonlikedict/relationship_parser.py
@@ -125,6 +125,7 @@ def parse_document_describes(
     def parse_has_files(
         self, package_dicts: List[Dict], existing_relationships: List[Relationship]
     ) -> List[Relationship]:
+        # assume existing relationships are stripped of comments
         logger = Logger()
         contains_relationships = []
         for package in package_dicts:
diff --git a/tests/spdx/parser/jsonlikedict/test_relationship_parser.py b/tests/spdx/parser/jsonlikedict/test_relationship_parser.py
@@ -169,14 +169,14 @@ def test_parse_has_files():
 @pytest.mark.parametrize(
     "has_files,existing_relationships,contains_relationships",
     [
+        # pre-requisite for parse_has_files requires that comments in relationships are stripped
         (
             ["SPDXRef-File1", "SPDXRef-File2"],
             [
                 Relationship(
                     spdx_element_id="SPDXRef-Package",
                     relationship_type=RelationshipType.CONTAINS,
                     related_spdx_element_id="SPDXRef-File1",
-                    comment="This relationship has a comment.",
                 ),
                 Relationship(
                     spdx_element_id="SPDXRef-File2",

Original file line number	Diff line number	Diff line change
`@@ -169,14 +169,14 @@ def test_parse_has_files():`
`169`	`169`	`@pytest.mark.parametrize(`
`170`	`170`	`"has_files,existing_relationships,contains_relationships",`
`171`	`171`	`[`
	`172`	`+ # pre-requisite for parse_has_files requires that comments in relationships are stripped`
`172`	`173`	`(`
`173`	`174`	`["SPDXRef-File1", "SPDXRef-File2"],`
`174`	`175`	`[`
`175`	`176`	`Relationship(`
`176`	`177`	`spdx_element_id="SPDXRef-Package",`
`177`	`178`	`relationship_type=RelationshipType.CONTAINS,`
`178`	`179`	`related_spdx_element_id="SPDXRef-File1",`
`179`		`- comment="This relationship has a comment.",`
`180`	`180`	`),`
`181`	`181`	`Relationship(`
`182`	`182`	`spdx_element_id="SPDXRef-File2",`