8000 drivers, wiznet5k: Fix IP addr verification. · sparkfun/circuitpython@812cf62 · GitHub
[go: up one dir, main page]

Skip to content

Commit 812cf62

8000 Browse files
committed
drivers, wiznet5k: Fix IP addr verification.
1 parent 71224cb commit 812cf62

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/wiznet5k/ethernet/socket.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,8 @@ int8_t connect(uint8_t sn, uint8_t * addr, uint16_t port)
195195
taddr = ((uint32_t)addr[0] & 0x000000FF);
196196
taddr = (taddr << 8) + ((uint32_t)addr[1] & 0x000000FF);
197197
taddr = (taddr << 8) + ((uint32_t)addr[2] & 0x000000FF);
198-
taddr = (taddr << 8) + ((uint32_t)addr[0] & 0x000000FF);
199-
if( taddr == 0xFFFFFFFF || taddr == 0) return SOCKERR_IPINVALID;
198+
taddr = (taddr << 8) + ((uint32_t)addr[3] & 0x000000FF);
199+
if (taddr == 0xFFFFFFFF || taddr == 0) return SOCKERR_IPINVALID;
200200
}
201201
//
202202

@@ -369,9 +369,9 @@ int32_t sendto(uint8_t sn, uint8_t * buf, uint16_t len, uint8_t * addr, uint16_t
369369
taddr = (taddr << 8) + ((uint32_t)addr[1] & 0x000000FF);
370370
taddr = (taddr << 8) + ((uint32_t)addr[2] & 0x000000FF);
371371
taddr = (taddr << 8) + ((uint32_t)addr[3] & 0x000000FF);
372+
if (taddr == 0xFFFFFFFF || taddr == 0) return SOCKERR_IPINVALID;
372373
}
373374
//
374-
if(*((uint32_t*)addr) == 0) return SOCKERR_IPINVALID;
375375
if(port == 0) return SOCKERR_PORTZERO;
376376
tmp = getSn_SR(sn);
377377
if(tmp != SOCK_MACRAW && tmp != SOCK_UDP) return SOCKERR_SOCKSTATUS;

0 commit comments

Comments
 (0)
0