8000 getProtocolVersion overruns payloadCfg array · Issue #73 · sparkfun/SparkFun_Ublox_Arduino_Library · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

getProtocolVersion overruns payloadCfg array #73

Closed
matthewgkerr opened this issue Feb 12, 2020 · 6 comments
Closed

getProtocolVersion overruns payloadCfg array #73

matthewgkerr opened this issue Feb 12, 2020 · 6 comments

Comments

@matthewgkerr
Copy link

payloadCfg currently has a defined size of 256 (MAX_PAYLOAD_SIZE) bytes. Base on the comment "We need ~220 bytes for getProtocolVersion on most ublox modules" I believe the expectation is most modules will contain no more than 6 extensions (payload: 30 + 10 + 6*30 = 220 bytes). getProtocolVersion is currently configured to step through 10 extensions (340 bytes) which will overrun payloadCfg.
@mayopan
Copy link
mayopan commented Feb 17, 2020

Hi, matthewgkerr.
I found the same issue, and fixed it by a little modification.
Please try My repo for getProtocolVersion.
If it works in your circumstance, I'll make PR for it.

I think the official master version has another bug yet.
I can't change baud rate or other setting changes.OR
So I have to arrange the baud rate to that of connected public gps.
This bug lies in the new method of "ack", I think.
I'm looking in it now.

@mayopan
Copy link
mayopan commented Feb 17, 2020 •
edited
Loading

And one more thing.
I want to know not only the version number, but also all other extension information of ublox gps module, as such you can see in U-center software.
So I made an additional function "getModuleInfo".
It outputs the text arrays as named structure.
Try it too, if you are interested.

There is a sample code in the same #8 example folder as the getProtocolVersion.

@fm4dd
Copy link
fm4dd commented Apr 9, 2020

I want to know not only the version number, but also all other extension information of ublox gps module, as such you can see in U-center software.
So I made an additional function "getModuleInfo".

Looks great! You should create a PR for it.

Example run on a SAM-M8Q:

Module Info : 
Soft version: ROM CORE 3.01 (107888)
Hard version: 00080000
Extensions:
  FWVER=SPG 3.01
  PROTVER=18.00
  GPS;GLO;GAL;BDS
  SBAS;IMES;QZSS

Done!

@PaulZC
Copy link
Collaborator
PaulZC commented Apr 22, 2020

Hi @matthewgkerr & @mayopan ,
We need to be careful that we don't increase the RAM usage for most users. The library already needs more than half of the available RAM on ATmega328P platforms. So I'm afraid increasing the default buffer size inside the library is not going to be possible.
But, if your platform has RAM to spare, there are now two possible ways forward without modifying the library:

  • #define MAX_PAYLOAD_SIZE 512 before the #include "SparkFun_Ublox_Arduino_Library.h" in your .ino. This will override the MAX_PAYLOAD_SIZE and create extra space for the module info.
  • Use the new custom packet feature to define your own packet with a larger payload in your .ino. Please see the new Example20 for details.

I am going to close this issue but please reopen it if you are still having problems.
Enjoy!
Paul

@PaulZC PaulZC closed this as completed Apr 22, 2020
@mayopan mayopan mentioned this issue May 4, 2020
Closed
@mayopan
Copy link
mayopan commented May 15, 2020 •
edited
Loading

I want to know not only the version number, but also all other extension information of ublox gps module, as such you can see in U-center software.
So I made an additional function "getModuleInfo".

Looks great! You should create a PR for it.

Example run on a SAM-M8Q:

Module Info : 
Soft version: ROM CORE 3.01 (107888)
Hard version: 00080000
Extensions:
  FWVER=SPG 3.01
  PROTVER=18.00
  GPS;GLO;GAL;BDS
  SBAS;IMES;QZSS

Done!

The new example21 has been added in the latest commit of original library.
It shows how to use the same function getModuleInfo without library modification.
Enjoy!

@nseidle
Copy link
Member
nseidle commented Sep 26, 2020

Hi @mayopan - just wanted to say thanks for your contribution! I needed to grab hwVersion for one of my projects and your solution and example are perfect.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nseidle @matthewgkerr @fm4dd @PaulZC @mayopan
0