8000 Support Perforce changelists in `src code-intel upload` · Issue #1035 · sourcegraph/src-cli · GitHub
[go: up one dir, main page]

Skip to content

Support Perforce changelists in src code-intel upload #1035

@varungandhi-src

Description

@varungandhi-src

Right now, there is a -commit flag, but if you try to pass a Perforce changelist, but the backend validates that the value is a Git hash.

unexpected status code: 400 (failed to enqueue payload: commit must be a 40-character revhash)

We should perhaps keep using the same flag, but have it allow passing a changelist instead.

In terms of design, perhaps we should require a cl:<blah> format (or similar) instead of accepting a bare identifier and then just assume that it is a changelist if it is not a 40-character hash. That way, we can add support for other formats later without having to have complicated inference logic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0