8000 Document how to get proper stack traces in tests · Issue #95 · sourcegraph/scip-python · GitHub
[go: up one dir, main page]
Skip to content

Document how to get proper stack traces in tests #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
varungandhi-src opened this issue Aug 18, 2023 · 1 comment · Fixed by #96
Closed

Document how to get proper stack traces in tests #95

varungandhi-src opened this issue Aug 18, 2023 · 1 comment · Fixed by #96
Labels
documentation Improvements or additions to documentation

Comments

@varungandhi-src
Copy link
Contributor
varungandhi-src commented Aug 18, 2023 •
edited
Loading

It seems like whatever the webpack configuration is by default, if you do npm run webpack (do a dev build) and then npm run check-snapshots, the stack traces point inside dist/scip-python.js instead of the TypeScript files.

I'm assuming there is a way to configure the source maps properly to provide more useful stack traces (there is a line in webpack.config.js which I'm guessing is supposed to this... https://sourcegraph.com/github.com/sourcegraph/scip-python/-/blob/packages/pyright-scip/webpack.config.js?L33), it's just that I haven't figured it out yet.
@varungandhi-src varungandhi-src added the documentation Improvements or additions to documentation label Aug 18, 2023
@varungandhi-src
Copy link
Contributor Author

Just needs an extra flag in the testing line node --enable-source-maps <other flags>

@varungandhi-src varungandhi-src mentioned this issue Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Point stack traces to TypeScript sources sourcegraph/scip-python
1 participant
@varungandhi-src
0