8000 Support bazel repositories by documenting environment file format · Issue #45 · sourcegraph/scip-python · GitHub
[go: up one dir, main page]
Skip to content

Support bazel repositories by documenting environment file format #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jlisee opened this issue Jul 6, 2022 · 4 comments
Open

Support bazel repositories by documenting environment file format #45

jlisee opened this issue Jul 6, 2022 · 4 comments
Assignees
@tjdevries @varungandhi-src
Labels
graph/scip-python team/graph

Comments

@jlisee
Copy link
jlisee commented Jul 6, 2022

Is your feature request related to a problem? Please describe.

When trying to run scip-python on my Bazel based repository with a non-standard requirements.txt location and no use of pip the program locks up in the Evaluating python environment dependencies stage.

Describe the solution you'd like

I would like to be able to generate the dependency map myself since our repository installs dependencies through Bazel, hence files are in non-standard locations and the requirements.txt file has a non-standard location and path.

We have enough automation in place that will be straight forward to maintain, and way easier than trying to tool to understand our build system.

Additional context

Pyright itself works fine with just using [tool.pyright] extraPaths in our pyproject.toml to find these locations, a sample simple configuration:

[tool.pyright]
# Pylance plugin does not have an option to exclude paths so we do it here
exclude = ["bazel-av", "bazel-out", "bazel-bin", "bazel-external", "bazel-testlogs", "external", "avos-build", ".git", "**/node_modules", "**/__pycache__"]
extraPaths = [
    # For each library
    "./external/internal_pip_dependency_click/pypi__click",
    "./external/internal_pip_dependency_gitpython/pypi__gitpython",
    "./external/internal_pip_dependency_more_itertools/pypi__more_itertools",
    "./external/internal_pip_dependency_pytest/pypi__pytest",
    "./external/internal_pip_dependency_pyyaml/pypi__pyyaml",
    "./external/internal_pip_dependency_tabulate/pypi__tabulate",
    # For generated code like protobufs
    "./bazel-bin",
]
@jlisee
Copy link
Author
jlisee commented Jul 8, 2022

Those folders are unpacked wheels that contain a click-8.0.4.dist-info folder:

$ find external/internal_pip_dependency_click/pypi__click/
external/internal_pip_dependency_click/pypi__click/
external/internal_pip_dependency_click/pypi__click/BUILD
external/internal_pip_dependency_click/pypi__click/click-8.0.4.dist-info
external/internal_pip_dependency_click/pypi__click/click-8.0.4.dist-info/WHEEL
external/internal_pip_dependency_click/pypi__click/click-8.0.4.dist-info/METADATA
external/internal_pip_dependency_click/pypi__click/click-8.0.4.dist-info/RECORD
external/internal_pip_dependency_click/pypi__click/click-8.0.4.dist-info/top_level.txt
external/internal_pip_dependency_click/pypi__click/click-8.0.4.dist-info/LICENSE.rst
external/internal_pip_dependency_click/pypi__click/click
external/internal_pip_dependency_click/pypi__click/click/parser.py
external/internal_pip_dependency_click/pypi__click/click/utils.py
external/internal_pip_dependency_click/pypi__click/click/testing.py
external/internal_pip_dependency_click/pypi__click/click/_unicodefun.py
external/internal_pip_dependency_click/pypi__click/click/termui.py
external/internal_pip_dependency_click/pypi__click/click/exceptions.py
external/internal_pip_dependency_click/pypi__click/click/_winconsole.py
external/internal_pip_dependency_click/pypi__click/click/types.py
external/internal_pip_dependency_click/pypi__click/click/shell_completion.py
external/internal_pip_dependency_click/pypi__click/click/__init__.py
external/internal_pip_dependency_click/pypi__click/click/_compat.py
external/internal_pip_dependency_click/pypi__click/click/py.typed
external/internal_pip_dependency_click/pypi__click/click/_textwrap.py
external/internal_pip_dependency_click/pypi__click/click/globals.py
external/internal_pip_dependency_click/pypi__click/click/formatting.py
external/internal_pip_dependency_click/pypi__click/click/core.py
external/internal_pip_dependency_click/pypi__click/click/_termui_impl.py
external/internal_pip_dependency_click/pypi__click/click/decorators.py

@tjdevries tjdevries self-assigned this Jul 13, 2022
@varungandhi-src varungandhi-src self-assigned this Aug 31, 2022
@varungandhi-src
Copy link
Contributor

Hi @jlisee, trying to catch up here since TJ is out on leave. Could you clarify the following for me:

  1. Did you have a separate convo in Slack/Zoom with TJ about this after filing this issue -- is there something else that is needed from your side?
  2. Are you entirely blocked from being able to use scip-python or have you been able to figure out a workaround?

@jlisee
Copy link
Author
jlisee commented Sep 1, 2022 •
edited
Loading

Blocked?
No, I am not blocked. I created a workaround by making stub pip binary that returns empty results. This enables indexing to complete successfully and be usable in a private Sourcegraph instance. Since we have a monorepository, and third party code is not indexed by our instance, this package information missing does not hurt us.

Fixed?
No. I would like to be able to:

  • Disable the querying of this information with something like a CLI flag
  • Supply the information directly in a well documented format like a JSON file

@timhirsh timhirsh mentioned this issue May 1, 2023
Open
@tjdevries
Copy link
Contributor

With the latest configuration changes from #77, I think this should be possible now (and should also re-use any existing pyright configuration you have).

Does the current README give you enough info to do what you're looking for?

@mmanela mmanela added the Migrated label May 6, 2024 — with Linear
@eseliger eseliger removed the Migrated label May 21, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjdevries tjdevries

@varungandhi-src varungandhi-src

Labels
graph/scip-python team/graph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mmanela @jlisee @tjdevries @eseliger @varungandhi-src
0