Changed reportImplicitOverride check to exempt __init__ and __new__ methods, as per guidance from PEP 698's author. This addresses microsoft/pyright#4823.

msfterictraut · msfterictraut · commit 1a0731e31cdc · 2023-03-30T20:51:34.000-07:00
diff --git a/packages/pyright-internal/src/analyzer/checker.ts b/packages/pyright-internal/src/analyzer/checker.ts
@@ -5338,6 +5338,11 @@ export class Checker extends ParseTreeWalker {
             return;
         }
 
+        // Constructors are exempt.
+        if (overrideFunction.details.name === '__init__' || overrideFunction.details.name === '__new__') {
+            return;
+        }
+
         const funcNode = overrideFunction.details.declaration.node;
         this._evaluator.addDiagnostic(
             this._fileInfo.diagnosticRuleSet.reportImplicitOverride,
diff --git a/packages/pyright-internal/src/tests/samples/override2.py b/packages/pyright-internal/src/tests/samples/override2.py
@@ -14,7 +14,6 @@ def method1(self):
 
 
 class Child(Base):
-    # This should generate an error if reportImplicitOverride is enabled.
     def __init__(self):
         pass
 
diff --git a/packages/pyright-internal/src/tests/typeEvaluator5.test.ts b/packages/pyright-internal/src/tests/typeEvaluator5.test.ts
@@ -163,7 +163,7 @@ test('Override2', () => {
 
     configOptions.diagnosticRuleSet.reportImplicitOverride = 'error';
     const analysisResults2 = TestUtils.typeAnalyzeSampleFiles(['override2.py'], configOptions);
-    TestUtils.validateResults(analysisResults2, 2);
+    TestUtils.validateResults(analysisResults2, 1);
 });
 
 test('TypeVarDefault1', () => {
