Fixed bug in constraint solver that results in incorrect code being emitted when overriding a method that includes multiple keyword-only parameters. This addresses microsoft/pylance-release#4173.

msfterictraut · msfterictraut · commit 09c79ed3e284 · 2023-03-30T15:05:12.000-07:00
diff --git a/packages/pyright-internal/src/languageService/completionProvider.ts b/packages/pyright-internal/src/languageService/completionProvider.ts
@@ -1431,15 +1431,20 @@ export class CompletionProvider {
         function getParameters(parameters: ParameterNode[]) {
             const results: [node: ParameterNode, keywordOnly: boolean][] = [];
 
-            let keywordOnly = false;
+            let sawKeywordOnlySeparator = false;
             for (const parameter of parameters) {
                 if (parameter.name) {
-                    results.push([parameter, keywordOnly]);
+                    results.push([
+                        parameter,
+                        parameter.category === ParameterCategory.Simple && !!parameter.name && sawKeywordOnlySeparator,
+                    ]);
                 }
 
-                keywordOnly =
-                    parameter.category === ParameterCategory.VarArgList ||
-                    parameter.category === ParameterCategory.VarArgDictionary;
+                // All simple parameters after a `*` or `*args` parameter
+                // are considered keyword only.
+                if (parameter.category === ParameterCategory.VarArgList) {
+                    sawKeywordOnlySeparator = true;
+                }
             }
 
             return results;
