code_style: calculate bounds only when it is needed

love-linger · love-linger · commit 6986e1ac24ce · 2025-05-08T13:42:21.000+08:00
Signed-off-by: leo &lt;longshuang@msn.cn&gt;
diff --git a/src/Views/CommitGraph.cs b/src/Views/CommitGraph.cs
@@ -55,11 +55,6 @@ public override void Render(DrawingContext context)
             if (list == null)
                 return;
 
-            // Calculate drawing area.
-            var width = histories.CommitListHeader.ColumnDefinitions[0].ActualWidth;
-            var height = Bounds.Height;
-
-            // Calculate row height
             var container = list.ItemsPanelRoot as VirtualizingStackPanel;
             if (container == null)
                 return;
@@ -68,15 +63,15 @@ public override void Render(DrawingContext context)
             if (item == null)
                 return;
 
+            var width = histories.CommitListHeader.ColumnDefinitions[0].ActualWidth;
+            var height = Bounds.Height;
             var rowHeight = item.Bounds.Height;
             var startY = container.FirstRealizedIndex * rowHeight - item.TranslatePoint(new Point(0, 0), list).Value!.Y;
             var endY = startY + height + 28;
 
-            // Apply scroll offset and clip.
             using (context.PushClip(new Rect(0, 0, width, height)))
             using (context.PushTransform(Matrix.CreateTranslation(0, -startY)))
             {
-                // Draw contents
                 DrawCurves(context, graph, startY, endY, rowHeight);
                 DrawAnchors(context, graph, startY, endY, rowHeight);
             }
