Add tests to ensure passing a bogus role/filter won't be passed through to the API

mwielgoszewski · mwielgoszewski · commit c86e2a290ea0 · 2015-07-21T12:20:44.000-04:00
diff --git a/tests/unit/test_orgs.py b/tests/unit/test_orgs.py
@@ -284,6 +284,17 @@ def test_members_filters(self):
             headers={}
         )
 
+    def test_members_excludes_fake_filters(self):
+        """Show that one cannot pass a bogus filter to the API."""
+        i = self.instance.members(filter='bogus-filter')
+        self.get_next(i)
+
+        self.session.get.assert_called_once_with(
+            url_for('members'),
+            params={'per_page': 100},
+            headers={}
+        )
+
     def test_members_roles(self):
         """Show that one can iterate over all admins."""
         i = self.instance.members(role='admin')
@@ -295,6 +306,17 @@ def test_members_roles(self):
             headers={'Accept': 'application/vnd.github.ironman-preview+json'}
         )
 
+    def test_members_excludes_fake_roles(self):
+        """Show that one cannot pass a bogus role to the API."""
+        i = self.instance.members(role='bogus-role')
+        self.get_next(i)
+
+        self.session.get.assert_called_once_with(
+            url_for('members'),
+            params={'per_page': 100},
+            headers={}
+        )
+
     def test_public_members(self):
         """Show that one can iterate over all public members."""
         i = self.instance.public_members()
diff --git a/tests/unit/test_orgs_team.py b/tests/unit/test_orgs_team.py
@@ -168,6 +168,17 @@ def test_members_roles(self):
             headers={'Accept': 'application/vnd.github.ironman-preview+json'}
         )
 
+    def test_members_excludes_fake_roles(self):
+        """Show that one cannot pass a bogus role to the API."""
+        i = self.instance.members(role='bogus-role')
+        self.get_next(i)
+
+        self.session.get.assert_called_once_with(
+            url_for('members'),
+            params={'per_page': 100},
+            headers={}
+        )
+
     def test_members_requires_auth(self):
         """Show that one needs to authenticate to get team members."""
         self.session.has_auth.return_value = False
