the sum of two integer may overflow. #37
Merged
soulmachine merged 1 commit intosoulmachine:masterfrom Dec 2, 2014
Merged
Conversation
Owner
|
你的这个改动很好，不过本书的代码，更加注重可读性。 如果连简单的 x+y 都要考虑溢出，那代码会变得非常难懂 |
Contributor
Author
|
Owner
|
我重新grep了一把，发现以前的确有很多防止溢出的写法，那这个也采纳吧，非常感谢！ |
soulmachine
added a commit
that referenced
this pull request
Dec 2, 2014
the sum of two integer may overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html
for details.