8000 Disable debug selector, it's purpose is more robustly handled by `::R… · socketry/async-rspec@5c6484f · GitHub
[go: up one dir, main page]

Skip to content

Commit 5c6484f

Browse files
committed
Disable debug selector, it's purpose is more robustly handled by ::RSpec::Files::Leaks.
1 parent 575bbfa commit 5c6484f

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

async-rspec.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
1818
spec.add_dependency "rspec-memory", "~> 1.0"
1919

2020
spec.add_development_dependency "async", "~> 1.24"
21+
spec.add_development_dependency "async-io"
2122
spec.add_development_dependency "bundler"
2223
spec.add_development_dependency "covered"
2324
spec.add_development_dependency "rake", "~> 10.0"

lib/async/rspec/reactor.rb

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@
2121
require_relative 'leaks'
2222

2323
require 'kernel/async'
24-
2524
require 'async/reactor'
26-
require 'async/debug/selector'
2725

2826
module Async
2927
module RSpec
@@ -79,8 +77,7 @@ def run_in_reactor(reactor, duration = nil)
7977

8078
::RSpec.shared_context Reactor do
8179
include Reactor
82-
83-
let(:reactor) {Async::Reactor.new(selector: Async::Debug::Selector.new)}
80+
let(:reactor) {Async::Reactor.new}
8481

8 8000 582
include_context Async::RSpec::Leaks
8683

spec/async/rspec/reactor_spec.rb

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
# THE SOFTWARE.
2020

2121
require 'async/rspec/reactor'
22+
require 'async/io/generic'
2223

2324
RSpec.describe Async::RSpec::Reactor do
2425
context "with shared context", timeout: 1 do
@@ -54,17 +55,19 @@
5455
include_context Async::RSpec::Reactor
5556

5657
it "should fail if registering the same io twice" do
57-
input, output = IO.pipe
58+
input, output = IO.pipe.map{|io| Async::IO::Generic.new(io)}
5859

59-
monitor = reactor.register(input, :r)
60+
reactor.async do
61+
input.read
62+
end
6063

6164
expect do
62-
reactor.register(input, :r)
63-
end.to raise_error(RuntimeError, /already registered/)
64-
65-
monitor.close
66-
input.close
67-
output.close
65+
input.read
66+
end.to raise_error(/already registered|already waiting/)
67+
68+
ensure
69+
input&.close
70+
output&.close
6871
end
6972
end
7073

0 commit comments

Comments
 (0)
0